generated from multiversx/mx-template-sc
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a note about audit in multisig SC #123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage SummaryTotals
FilesExpand
|
ccorcoveanu
reviewed
Nov 12, 2024
contracts/multisig/README.md
Outdated
@@ -11,6 +11,10 @@ As an example, let us imagine the following scenario. An institution launches a | |||
|
|||
Thus, essentially the multisig SC (we will refer to it, from now on, as MSC) enables multiple parties to sign or approve an action that takes place - typically a requirement for certain wallets, accounts, and smart contracts to prevent a rogue or hacked individual from performing detrimental actions. | |||
|
|||
## Developer's note | |||
|
|||
Starting with the release version v0.45.5 of mx-contracts-rs, this contract has beed audited and changed to meet the required standards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd actually be more specific in saying that: release version v0.45.5 is the audited version for the multisig contract and link to it here: https://github.com/multiversx/mx-contracts-rs/releases/tag/v0.45.5
- this way there's no confusion weather other releases touch or change the code in some way - as we seen, releases that do not touch the multisig at all can also break something in this mono-repo style
andreiblt1304
approved these changes
Nov 20, 2024
ccorcoveanu
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.