Speed up check - early checks #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmhost/contexts/validator.go
Outdated
| return err | ||
| } | ||
|
|
||
| errInvalidName := fmt.Errorf("%w: %s", vmhost.ErrInvalidFunctionName, functionName) |
There was a problem hiding this comment.
maybe %x for the function name? As it covers the situation where there are not ASCII characters involved
| @@ -78,9 +92,6 @@ func (validator *wasmValidator) verifyValidFunctionName(functionName string) err | |||
| if !validCharactersOnly(functionName) { | |||
There was a problem hiding this comment.
👍
the list to be checked is "abcdefghijklmnopqrstuvwxyz0123456789_"
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #809 +/- ##
==========================================
+ Coverage 42.06% 42.10% +0.03%
==========================================
Files 49 49
Lines 9221 9230 +9
==========================================
+ Hits 3879 3886 +7
- Misses 4895 4896 +1
- Partials 447 448 +1 ☔ View full report in Codecov by Sentry. |
iulianpascalau
approved these changes
Jan 9, 2024
andreibancioiu
approved these changes
Jan 9, 2024
raduchis
approved these changes
Jan 9, 2024
mariusmihaic
approved these changes
Jan 9, 2024
andrei-marinica
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.