Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return err if no upgrade init func #784

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

sasurobert
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (41c60e3) 42.16% compared to head (136cc28) 42.16%.

❗ Current head 136cc28 differs from pull request most recent head 9fedfca. Consider uploading reports for the commit 9fedfca to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   42.16%   42.16%           
=======================================
  Files          49       49           
  Lines        9200     9200           
=======================================
  Hits         3879     3879           
  Misses       4878     4878           
  Partials      443      443           
Files Coverage Δ
vmhost/hostCore/execution.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iulianpascalau iulianpascalau self-requested a review October 5, 2023 07:50
@sasurobert sasurobert merged commit bb383e6 into master Oct 5, 2023
3 checks passed
@iulianpascalau iulianpascalau deleted the return-err-if-no-upgrade-init-func branch October 5, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants