Test pruning storer #6667
Test pruning storer #6667
Conversation
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
BeniaminDrasovean
changed the base branch from
master
to
rc/spica-patch-relayedv3
BeniaminDrasovean
dismissed
sasurobert’s stale review
The base branch was changed.
|
|
storage/pruning/pruningStorer.go
Outdated
| return ps.removeOldPersistersIfNeeded(header, epoch) | ||
| } | ||
|
|
||
| func (ps *PruningStorer) removeOldPersistersIfNeeded(header data.HeaderHandler, epoch uint32) error { |
There was a problem hiding this comment.
can we pass only one argument, either the epoch or the header?
|
|
There was a problem hiding this comment.
Normal allin test: v1.8.4-dev-config-171a31edab -> test-pruning-storer-fee796fb44
--- Specific errors ---
block hash does not match 1907
wrong nonce in block 829
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 416
Nr. of new ERRORS: 0
Nr. of new WARNS: 15
Nr. of PANICS: 0
Nodes with panic: []
/------/
--- System test go ---
All scenarios from system-test-go are OK!
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
|
|
BeniaminDrasovean
merged commit 6a74c03
into
rc/spica-patch-relayedv3
Reasoning behind the pull request
dbLookupExtensionset totrue, it will not remove any old dbs. In this case the node will create aFullHistoryPruningStorerthat can create a new db for a new epoch if some methods are called. When thechangeEpochtrigger is activated, the new db already exists, thus not executing the code that should close older dbs.Proposed changes
changeEpoch, even if a db was already created, also check if older dbs need to be removedTesting procedure
full-archive,db-lookup-extension,historical-balances,snapshotless-observernode operation mode and check that the dbs will be kept or removed as they should be.Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?