Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Header version factory #6658

Merged

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Dec 6, 2024

Reasoning behind the pull request

  • Backwards compatibility issues for other sovereign chains if we change the header or if internal Header is changed on mainnet.

Proposed changes

  • Sovereign header version factory

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Dec 6, 2024
Base automatically changed from MX-16228-inject-delegated-staked-factory-into-runtype to feat/chain-go-sdk December 9, 2024 10:01
@mariusmihaic mariusmihaic marked this pull request as ready for review December 11, 2024 10:24
@sasurobert sasurobert self-requested a review December 11, 2024 10:35
Copy link
Contributor

@axenteoctavian axenteoctavian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the comment in the other PR
multiversx/mx-chain-core-go#337

@mariusmihaic mariusmihaic merged commit 510397f into feat/chain-go-sdk Dec 13, 2024
4 checks passed
@mariusmihaic mariusmihaic deleted the MX-15667-sovereign-header-version-creator branch December 13, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants