add concurrency unit tests #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trie-concurrency-unit-tests # Conflicts: # trie/patriciaMerkleTrie_test.go
sasurobert
previously approved these changes
Dec 11, 2024
…trie-concurrency-unit-tests # Conflicts: # trie/interface.go
…trie-concurrency-unit-tests
ssd04
previously approved these changes
Dec 16, 2024
| }) | ||
| } | ||
|
|
||
| func TestPatricianMerkleTrie_ConcurrentOperations(t *testing.T) { |
There was a problem hiding this comment.
add concurrency test with all operations in parallel
There was a problem hiding this comment.
Will add for each PR the tests missing related to which trie func was refactored in that PR.
Base automatically changed from
refactor-trie-mutex-usage
to
feat/trie-mutex-refactor
December 18, 2024 09:23
BeniaminDrasovean
dismissed stale reviews from ssd04 and sasurobert
The base branch was changed.
sasurobert
approved these changes
Dec 18, 2024
ssd04
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?