updated core enums in state changes. #6495
Conversation
|
This PR should be taken into consideration too: multiversx/mx-chain-core-go#324 |
errors/errors.go
Outdated
| @@ -601,3 +601,6 @@ var ErrNilEpochSystemSCProcessor = errors.New("nil epoch system SC processor") | |||
|
|
|||
| // ErrNilRelayedTxV3Processor signals that a nil relayed tx v3 processor has been provided | |||
| var ErrNilRelayedTxV3Processor = errors.New("nil relayed tx v3 processor") | |||
|
|
|||
| // ErrOnlyReadStateChangesToCollect signals that only read state changes to collect have been configured to be collected. | |||
| var ErrOnlyReadStateChangesToCollect = errors.New("cannot collect only read state changes") | |||
There was a problem hiding this comment.
This is not used
There was a problem hiding this comment.
right. will remove it
config/config.go
Outdated
| SnapshotsEnabled bool | ||
| AccountsStatePruningEnabled bool | ||
| PeerStatePruningEnabled bool | ||
| StateChangesDataAnalysis bool |
There was a problem hiding this comment.
this change needs to be reflected also in config.toml
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestStateComponents_ParseStateChangesTypesToCollect(t *testing.T) { |
| // Publish will export state changes | ||
| func (scc *dataAnalysisCollector) Publish() error { | ||
| // Publish will retrieve the state changes linked with the tx hash. | ||
| func (scc *dataAnalysisCollector) Publish() (map[string]*data.StateChanges, error) { |
There was a problem hiding this comment.
is this correct? this is the same as for normal collector.
my suggestion was to store into levelDB on this Publish, and avoid having Store function, since this component is used only for data analysis, not for the production flow, at least currently
There was a problem hiding this comment.
this will also save normal state changes to outport driver when running in data analysis mode, which i don't think we want
There was a problem hiding this comment.
yes, but in the current implementation if you don't have the outport driver configured you will never publish, hence the store function. If you have data analysis enabled and the host driver off, you will still have them persisted in leveldb.
| @@ -122,34 +125,48 @@ func (scf *stateComponentsFactory) Create() (*stateComponents, error) { | |||
| } | |||
|
|
|||
| func (scf *stateComponentsFactory) createStateChangesCollector() (state.StateChangesCollector, error) { | |||
There was a problem hiding this comment.
state changes collector is created 2 times in this file, it should be creating only once for main accounts db and then passed to peer accounts
There was a problem hiding this comment.
not related to this PR, but please fix this here
There was a problem hiding this comment.
I think we should have a different collector for PeerAccounts that can be disabled separately from config.
| @@ -122,34 +125,48 @@ func (scf *stateComponentsFactory) Create() (*stateComponents, error) { | |||
| } | |||
|
|
|||
| func (scf *stateComponentsFactory) createStateChangesCollector() (state.StateChangesCollector, error) { | |||
There was a problem hiding this comment.
I think we should have a different collector for PeerAccounts that can be disabled separately from config.
factory/state/stateComponents.go
Outdated
| opts = append(opts, stateChanges.WithCollectRead()) | ||
| } | ||
| if collectWrite { | ||
| opts = append(opts, stateChanges.WithCollectRead()) |
There was a problem hiding this comment.
.WithCollectWrite()
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?