Message validation optimization #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage_validation_optimization # Conflicts: # process/factory/interceptorscontainer/baseInterceptorsContainerFactory.go # process/factory/interceptorscontainer/metaInterceptorsContainerFactory.go # process/factory/interceptorscontainer/shardInterceptorsContainerFactory.go
AdoAdoAdo
requested changes
Sep 18, 2024
epochStart/bootstrap/factory/epochStartInterceptorsContainerFactory.go
Outdated
Show resolved
Hide resolved
AdoAdoAdo
reviewed
Sep 24, 2024
process/block/interceptedBlocks/interceptedMetaBlockHeader_test.go
Outdated
Show resolved
Hide resolved
process/factory/interceptorscontainer/baseInterceptorsContainerFactory.go
Outdated
Show resolved
Hide resolved
…essage_validation_optimization
AdoAdoAdo
reviewed
Sep 30, 2024
integrationTests/factory/bootstrapComponents/bootstrapComponents_test.go
Outdated
Show resolved
Hide resolved
process/factory/interceptorscontainer/baseInterceptorsContainerFactory.go
Outdated
Show resolved
Hide resolved
AdoAdoAdo
reviewed
Oct 1, 2024
AdoAdoAdo
previously approved these changes
Oct 1, 2024
sstanculeanu
reviewed
Oct 1, 2024
node/nodeRunner.go
Outdated
| @@ -321,7 +323,11 @@ func (nr *nodeRunner) executeOneComponentCreationCycle( | |||
| } | |||
|
|
|||
| log.Debug("creating bootstrap components") | |||
| managedBootstrapComponents, err := nr.CreateManagedBootstrapComponents(managedStatusCoreComponents, managedCoreComponents, managedCryptoComponents, managedNetworkComponents) | |||
| interceptedDataVerifierFactory := factory.NewInterceptedDataVerifierFactory(factory.InterceptedDataVerifierFactoryArgs{ | |||
There was a problem hiding this comment.
why not create it inside process components where it is being used?
the general config is already provided, no changes needed on nodeRunner
Co-authored-by: Sorin Stanculeanu <[email protected]>
sstanculeanu
reviewed
Oct 3, 2024
epochStart/bootstrap/process_test.go
Outdated
Comment on lines
999
to
1001
| epochStartProvider.interceptedDataVerifierFactory = &processMock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &processMock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| epochStartProvider.interceptedDataVerifierFactory = &processMock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &processMock.InterceptedDataVerifierMock{}, nil | |
| }} | |
| epochStartProvider.interceptedDataVerifierFactory = &processMock.InterceptedDataVerifierFactoryMock{} |
Comment on lines
132
to
134
| args.InterceptedDataVerifierFactory = &processMock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &processMock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &processMock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &processMock.InterceptedDataVerifierMock{}, nil | |
| }} | |
| args.InterceptedDataVerifierFactory = &processMock.InterceptedDataVerifierFactoryMock{} |
| @@ -62,13 +65,17 @@ func NewEpochStartMetaSyncer(args ArgsNewEpochStartMetaSyncer) (*epochStartMetaS | |||
| if check.IfNil(args.MetaBlockProcessor) { | |||
| return nil, epochStart.ErrNilMetablockProcessor | |||
| } | |||
| if check.IfNil(args.InterceptedDataVerifierFactory) { | |||
There was a problem hiding this comment.
still missing test for this
Comment on lines
270
to
274
| args.InterceptedDataVerifierFactory = &processMocks.InterceptedDataVerifierFactoryMock{ | ||
| CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &processMocks.InterceptedDataVerifierMock{}, nil | ||
| }, | ||
| } |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &processMocks.InterceptedDataVerifierFactoryMock{ | |
| CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &processMocks.InterceptedDataVerifierMock{}, nil | |
| }, | |
| } | |
| args.InterceptedDataVerifierFactory = &processMocks.InterceptedDataVerifierFactoryMock{} |
node/nodeRunner.go
Outdated
| @@ -321,7 +323,11 @@ func (nr *nodeRunner) executeOneComponentCreationCycle( | |||
| } | |||
|
|
|||
| log.Debug("creating bootstrap components") | |||
| managedBootstrapComponents, err := nr.CreateManagedBootstrapComponents(managedStatusCoreComponents, managedCoreComponents, managedCryptoComponents, managedNetworkComponents) | |||
| interceptedDataVerifierFactory := factory.NewInterceptedDataVerifierFactory(factory.InterceptedDataVerifierFactoryArgs{ | |||
sstanculeanu
reviewed
Oct 3, 2024
Comment on lines
549
to
551
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &mock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &mock.InterceptedDataVerifierMock{}, nil | |
| }} |
Comment on lines
567
to
569
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &mock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &mock.InterceptedDataVerifierMock{}, nil | |
| }} |
Comment on lines
602
to
604
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &mock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &mock.InterceptedDataVerifierMock{}, nil | |
| }} |
Comment on lines
656
to
658
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &mock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &mock.InterceptedDataVerifierMock{}, nil | |
| }} |
Comment on lines
500
to
502
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &mock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &mock.InterceptedDataVerifierMock{}, nil | |
| }} |
Comment on lines
569
to
571
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &mock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &mock.InterceptedDataVerifierMock{}, nil | |
| }} |
Comment on lines
607
to
609
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &mock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &mock.InterceptedDataVerifierMock{}, nil | |
| }} |
Comment on lines
660
to
662
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | ||
| return &mock.InterceptedDataVerifierMock{}, nil | ||
| }} |
There was a problem hiding this comment.
Suggested change
| args.InterceptedDataVerifierFactory = &mock.InterceptedDataVerifierFactoryMock{CreateCalled: func(topic string) (process.InterceptedDataVerifier, error) { | |
| return &mock.InterceptedDataVerifierMock{}, nil | |
| }} |
| @@ -79,6 +81,9 @@ func NewShardInterceptorsContainerFactory( | |||
| if check.IfNil(args.PeerSignatureHandler) { | |||
| return nil, process.ErrNilPeerSignatureHandler | |||
| } | |||
| if check.IfNil(args.InterceptedDataVerifierFactory) { | |||
| @@ -80,6 +81,9 @@ func NewMetaInterceptorsContainerFactory( | |||
| if check.IfNil(args.PeerSignatureHandler) { | |||
| return nil, process.ErrNilPeerSignatureHandler | |||
| } | |||
| if check.IfNil(args.InterceptedDataVerifierFactory) { | |||
… into message_validation_optimization
… into message_validation_optimization
sstanculeanu
approved these changes
Oct 3, 2024
AdoAdoAdo
approved these changes
Oct 4, 2024
| ValidInterceptedData interceptedDataStatus = iota | ||
| InvalidInterceptedData | ||
| validInterceptedData interceptedDataStatus = iota | ||
| invalidInterceptedData | ||
|
|
||
| interceptedDataStatusBytesSize = 8 |
There was a problem hiding this comment.
maybe move the last const outside to have clearer the "enum" values for the status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?