Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/equivalent messages #5786

Draft
wants to merge 592 commits into
base: feat/consensus-size-changes
Choose a base branch
from

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: Patch coverage is 84.23326% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 80.37%. Comparing base (9fd067f) to head (d418058).

Files Patch % Lines
consensus/spos/bls/subroundBlock.go 60.16% 34 Missing and 15 partials ⚠️
consensus/spos/bls/subroundSignature.go 86.36% 6 Missing and 3 partials ⚠️
consensus/spos/consensusMessageValidator.go 82.60% 2 Missing and 2 partials ⚠️
.../block/interceptedBlocks/interceptedBlockHeader.go 80.00% 2 Missing and 2 partials ⚠️
consensus/spos/worker.go 97.02% 2 Missing and 1 partial ⚠️
consensus/spos/debug/equivalentMessagesDebugger.go 94.73% 1 Missing and 1 partial ⚠️
...ck/interceptedBlocks/interceptedMetaBlockHeader.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat/consensus-size-changes    #5786      +/-   ##
===============================================================
+ Coverage                        80.29%   80.37%   +0.07%     
===============================================================
  Files                              712      713       +1     
  Lines                            94365    94688     +323     
===============================================================
+ Hits                             75775    76105     +330     
+ Misses                           13286    13267      -19     
- Partials                          5304     5316      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ilincaseby and others added 28 commits September 13, 2024 12:26
refactor to use common functions for single/multi-key
AdoAdoAdo and others added 30 commits December 11, 2024 10:51
Fix header verification after equivalent proofs
…/mx-chain-go into fixes-header-sig-verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants