Merge pull request #80 from ElrondNetwork/rc/2022-july

`rc/2022 july`

.github/workflows/pr-tests.yml

@@ -2,9 +2,9 @@ name: Tests
 
 on:
   push:
-    branches: [ main, development, feat/* ]
+    branches: [ main, development, feat/*, rc/* ]
   pull_request:
-    branches: [ main, development, feat/* ]
+    branches: [ main, development, feat/*, rc/* ]
 
 jobs:
   test:

core/errors.go

@@ -106,3 +106,6 @@ var ErrNilLogger = errors.New("nil logger")
 
 // ErrNilGoRoutineProcessor signals that a nil go routine processor has been provided
 var ErrNilGoRoutineProcessor = errors.New("nil go routine processor")
+
+// ErrNilPubkeyConverter signals that a nil public key converter has been provided
+var ErrNilPubkeyConverter = errors.New("nil pubkey converter")

core/optionals.go

@@ -0,0 +1,13 @@
+package core
+
+// OptionalUint32 holds an optional uint32 value
+type OptionalUint32 struct {
+	Value    uint32
+	HasValue bool
+}
+
+// OptionalUint64 holds an optional uint64 value
+type OptionalUint64 struct {
+	Value    uint64
+	HasValue bool
+}

core/peerID.go

@@ -5,6 +5,12 @@ import "github.com/mr-tron/base58/base58"
 // PeerID is a p2p peer identity.
 type PeerID string
 
+// NewPeerID creates a new peer id or returns an error
+func NewPeerID(input string) (PeerID, error) {
+	pidBytes, err := base58.Decode(input)
+	return PeerID(pidBytes), err
+}
+
 // Bytes returns the peer ID as byte slice
 func (pid PeerID) Bytes() []byte {
 	return []byte(pid)

core/peerID_test.go

@@ -0,0 +1,28 @@
+package core
+
+import (
+	"bytes"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestNewPeerID(t *testing.T) {
+	t.Parallel()
+	t.Run("invalid string should error", func(t *testing.T) {
+		t.Parallel()
+
+		providedStr := "provided str"
+		_, err := NewPeerID(providedStr)
+		assert.NotNil(t, err)
+	})
+	t.Run("should work", func(t *testing.T) {
+		t.Parallel()
+
+		providedStr := "provided str"
+		providedPeerID := PeerID(providedStr)
+		pid, err := NewPeerID(providedPeerID.Pretty())
+		assert.Nil(t, err)
+		assert.True(t, bytes.Equal([]byte(providedPeerID), pid.Bytes()))
+	})
+}