This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 339
Scheduler dev #465
Draft
phdinh94
wants to merge
27
commits into
multipath-tcp:mptcp_v0.95
Choose a base branch
from
phdinh94:scheduler_dev
base: mptcp_v0.95
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Scheduler dev #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @phdinh94 Thank you for this pull request. Because there is no description on this PR, may I ask you what is your goal here and what is the the feature you want to add? Please edit the description. Also regarding the code style, we follow the same standards as the ones from the Linux kernel even if we are more relax on some points. Still, it is important to create incremental commits explaining the different modifications the reasons why you need that. It also means:
And the code should be applied on mptcp_trunk first. Do you mind looking at that please? |
phdinh94
force-pushed
the
scheduler_dev
branch
2 times, most recently
from
March 15, 2022 00:05
fd560be
to
1c1e66d
Compare
It looks like this PR is not ready (no explanation, left comments, etc.) → Switched to draft. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.