Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Scheduler dev #465

Draft
wants to merge 27 commits into
base: mptcp_v0.95
Choose a base branch
from
Draft

Conversation

phdinh94
Copy link

No description provided.

@matttbe
Copy link
Member

matttbe commented Feb 15, 2022

Hi @phdinh94

Thank you for this pull request.

Because there is no description on this PR, may I ask you what is your goal here and what is the the feature you want to add? Please edit the description.

Also regarding the code style, we follow the same standards as the ones from the Linux kernel even if we are more relax on some points. Still, it is important to create incremental commits explaining the different modifications the reasons why you need that. It also means:

  • it should not contains debug/experimental code, comments and log files
  • it should be checkpatch.pl compliant
  • modifications in non MPTCP code (e.g. TCP stack) should be avoided or well justified
  • duplicated code should be avoided,
  • etc.

And the code should be applied on mptcp_trunk first.

Do you mind looking at that please?

@phdinh94 phdinh94 force-pushed the scheduler_dev branch 2 times, most recently from fd560be to 1c1e66d Compare March 15, 2022 00:05
@matttbe matttbe marked this pull request as draft April 27, 2022 16:32
@matttbe
Copy link
Member

matttbe commented Apr 27, 2022

It looks like this PR is not ready (no explanation, left comments, etc.) → Switched to draft.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants