Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make alloc without std work #377

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix: make alloc without std work #377

merged 1 commit into from
Dec 6, 2024

Conversation

vmx
Copy link
Member

@vmx vmx commented Dec 6, 2024

During the refactor at 954e523 the ability to compile the multihash crate with alloc but without std was lost. Now it works again.

Fixes #375.

The CI failure on the codetable is unrelated and has a fix at #376.

@vmx
fix: make alloc without std work
88ba262 
During the refactor at 954e523 the
ability to compile the `multihash` crate with `alloc` but without
`std` was lost. Now it works again.

Fixes #375.
@vmx vmx merged commit 03f84e9 into master Dec 6, 2024
20 checks passed
@vmx vmx deleted the fix-alloc branch December 6, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@thomaseizinger thomaseizinger Awaiting requested review from thomaseizinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to compile with default-features = false and features = ["alloc"]
2 participants
@vmx @Stebalien