Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade syn and synstructure (#362) #363

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Conversation

jmg-duarte
Copy link
Contributor

@jmg-duarte jmg-duarte commented Jun 5, 2024

fixes #362
closes #350
closes #301

  • I've added an Ident to utils::Attrs since attr.meta.to_token_stream() now includes it.
  • I've also removed ParseError since it didn't seem to be used (and tests seemed to passed)

@jmg-duarte
Copy link
Contributor Author

@vmx stable (1.78) has different errors to 1.77, should I change the expected errors to match or should we change CI?

Personally, when I developed macros, I would pin them against the MSRV and test against it only

@vmx
Copy link
Member

vmx commented Jun 5, 2024

We currently only guarantee a MSRV for the main multihash crate with default features. We currently don't have one for the derive macro. One option is to add one (it would be 1.66.1). Though I think easiest for now would be to just update the test files to make them work with current stable Rust and be done.

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good. Thanks a lot for tackling this!

@vmx
Copy link
Member

vmx commented Jun 5, 2024

The code coverage issue is unrelated. Feel free to ignore it and I'll make a PR for it later, or change the tarpaulin action version to 0.30.0, which should make it work.

@jmg-duarte jmg-duarte requested a review from vmx June 6, 2024 11:50
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR!

@vmx vmx merged commit ebc14ba into multiformats:master Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updating dependencies on syn and synstructure.
2 participants