Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce Cid::const_new, which allows accessing Cids from const contexts #139

Closed
wants to merge 2 commits into from

Conversation

aatifsyed
Copy link

@vmx
Copy link
Member

vmx commented Jul 25, 2023

In case we really want to have const constructors (I'm not sure if it's really needed), what if we introduce our own Error::ReadError and Error::WriteError instead of the IO Errors? It would be a breaking change, but it would solve the problem in a cleaner way. What do others think about that idea?

@Stebalien
Copy link
Member

I think we'd have to try it and see.

@aatifsyed
Copy link
Author

Closing for the same reasons as multiformats/rust-multihash#331 (comment)

@aatifsyed aatifsyed closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cid const constructors unusable
3 participants