Support buffer with any byteOffset values instead of 0 (#201)

* Support buffer with any byteOffset values instead of 0 * chore: add unit test Co-authored-by: Tuyen Nguyen <[email protected]>
multiformats · Jun 23, 2021 · 2201344 · 2201344
1 parent a95b991
commit 2201344
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/convert.js b/src/convert.js
@@ -133,7 +133,7 @@ function port2bytes (port) {
  */
 function bytes2port (buf) {
   const view = new DataView(buf.buffer)
-  return view.getUint16(0)
+  return view.getUint16(buf.byteOffset)
 }
 
 /**

diff --git a/test/convert.spec.js b/test/convert.spec.js
@@ -81,5 +81,12 @@ describe('convert', () => {
         'c0a80001'
       )
     })
+
+    it('respects byteoffset during conversion', () => {
+      const bytes = convert.toBytes('sctp', '1234')
+      const buffer = new Uint8Array(bytes.byteLength + 5)
+      buffer.set(bytes, 5)
+      expect(convert.toString('sctp', buffer.subarray(5))).to.equal('1234')
+    })
   })
 })