Added an option to skip httpServer creation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if not, made webhook just return the listener method.
|
I upvote this Pull request. I was about creating one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios, the webhook can be just one route in a bigger web server, which sets up its own node httpServer.
In this case, the current implementation of Telebot will attempt to create its httpServer on the same host and port which will result in a conflict.
To avoid this, a new option is added which specifies that httpServer should not be created and that bot.start() should return a promise resolving to a listener function which then should be mounted manually onto the existing httpServer.