Add a socketTimeout option to timeout http requests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well I just realized looking at the telegram API that the getUpdates is a long polling request, so the default value is not good and should probably be 0 ( no timeout). However I still think that it is more reliable to have the connection timeout. Also when the socket timeout value is set, it should be checked to be greater than the getUpdates timeout. |
mrummuka
pushed a commit
to mrummuka/telebot
that referenced
this pull request
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option named socketTimeout for polling to set a socket read timeout for http requests to telegram. The default value is set to 30 seconds.
Otherwise there is no socket read timeout and connection can hang indefinitely on some systems.