Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions CI jobs for testing, linting, formatting etc #2

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

faern
Copy link
Member

@faern faern commented Jun 28, 2024

Adds some CI for sanity checking. Makes sure things don't break and we keep a good style and hygiene etc.

This CI is basically a copy paste of what the Mullvad app team has established as a good baseline CI for Rust crates in pfctl-rs and nftnl.

@faern faern requested a review from gregoire-mullvad June 28, 2024 07:53
@faern faern force-pushed the add-ci branch 3 times, most recently from e5c0b78 to 51af67c Compare July 23, 2024 13:54
@faern
Copy link
Member Author

faern commented Jul 23, 2024

I have requested to have a new release of trycmd cut, to fix the minimal-versions issue. Until this happens this PR is either blocked, we have to ignore the minimal-versions check, or work around it in some ugly way. assert-rs/snapbox#346 (comment)

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/cargo-audit.yml Show resolved Hide resolved
@faern faern force-pushed the add-ci branch 2 times, most recently from 0afe6ea to f1b8030 Compare July 24, 2024 11:38
Copy link
Member

@gregoire-mullvad gregoire-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@faern faern merged commit fdf15aa into main Jul 24, 2024
13 checks passed
@faern faern deleted the add-ci branch July 24, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants