Improve code type mappings #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoire-mullvad
approved these changes
Sep 27, 2024
There were no mappings for the type anyway. And after discussing it, we did not find any concrete use case for special casing identifiers. So we decided to not support it for now.
faern
force-pushed
the
improve-code-type-mappings
branch
from
f47fd59 to
cad8083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
block_commentto Rust, since it was missing.Also some small cleanup/improvements to the way
CodeTypeand its mappings were structured.Also removes the unused
CodeType::Identifierit was currently unused, and after discussing it we found no real world use case of special casing identifiers at the moment.