Upgrade mio and env_logger
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This vulnerability does not affect us, since this project does not use named pipes. But still good to make cargo audit happy
dlon
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faern)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the CI is complaining about RUSTSEC-2024-0019. This PR fixes that by simply upgrading
mio. We are not affected by the RUSTSEC since we don't use named pipes, but it does not hurt to makecargo audithappy.Also took the opportunity to upgrade
env_loggersince I saw they had a breaking release. This removes the dependency onwinapi🥳 (Not that it matters, because it's only pulled in when built as a binary, and we only build binaries for Linux, but anyway)This change is