Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-static-bins.sh to include packages for Fedora #48

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-static-bins.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# and with logging enabled (controlled by RUST_LOG env var)
#
# You need the static version of glibc installed for this to work.
# On Fedora/RHEL that's: glibc-static.
# On Fedora/RHEL that's: sudo dnf install -y rust cargo glibc-static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like the asymmetry between Ubuntu and Fedora now. One has the full command and one just has a package name. And one is rightfully just about glibc while the other lists all dependencies.

# On Debian/Ubuntu that's: libc6-dev.

RUSTFLAGS="-C target-feature=+crt-static" \
Expand Down
Loading