Add exponential backoff to socket accept #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
force-pushed
the
add-exponential-backoff-to-socket-accept
branch
from
e11e82d to
62e9694
Compare
mvd-ows
approved these changes
Oct 3, 2023
dlon
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faern)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain odd scenarios the
tcp2udpprocess on our WireGuard servers run out of file descriptors. Then it busy loops on the TCP accept call. Because accepting the socket fails, but it's left in the TCP accept queue, so it will try accepting the same socket again in next iteration.A crude solution to this is just to sleep between failed TCP accepts with a simple exponential backoff.
This PR supersedes #44
This change is