Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy failing CI. #56

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix clippy failing CI. #56

merged 1 commit into from
Aug 22, 2024

Conversation

mstyura
Copy link
Contributor

@mstyura mstyura commented Aug 21, 2024

Noticed that after my MR merged the CI is failing, hopefully this fixed it.


This change is Reviewable

@mstyura
Copy link
Contributor Author

mstyura commented Aug 21, 2024

@faern this MR should probably fix CI on main branch. At least locally cargo clippy --all-features --all-targets succeed now.

@faern
Copy link
Member

faern commented Aug 21, 2024

I noticed cargo test failed on main even before your PR also.

@faern
Copy link
Member

faern commented Aug 21, 2024

cargo test is still failing for me. From what I can tell test_service_order still fails. Does it pass for you locally?

@mstyura
Copy link
Contributor Author

mstyura commented Aug 21, 2024

On my local machine tests are "green":

cargo test                                 
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.11s
     Running unittests src/lib.rs (target/debug/deps/system_configuration-3fdd7b46168972d6)

running 10 tests
test network_configuration::test::test_empty_array ... ok
test preferences::tests::retain_count ... ok
test network_reachability::test::test_network_reachability_from_addr ... ok
test network_reachability::test::test_reachability_ref_from_host ... ok
test network_configuration::test::test_service_order ... ok
test network_reachability::test::test_sockaddr_pair_reachability ... ok
test network_configuration::test::test_get_type ... ok
test network_configuration::test::test_get_all_interfaces ... ok
test network_reachability::test::test_sockaddr_local_to_dns_google_pair_reachability ... ok
test network_reachability::test::assert_infallibility_of_setting_a_callback ... ok

test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.01s

     Running unittests src/lib.rs (target/debug/deps/system_configuration_sys-c05115564a7ec50e)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests system_configuration

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests system_configuration_sys

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s


cargo check --all --tests --examples --bins
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s
cargo clippy --all-features --all-targets 
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.11s

@faern
Copy link
Member

faern commented Aug 22, 2024

Ok! Not for me, but your changes also does not make anything worse. The cfg stuff is indeed something we should be updating. So let's merge this, even if the tests still fail for me locally.

@faern faern merged commit 282d8b9 into mullvad:main Aug 22, 2024
@mstyura
Copy link
Contributor Author

mstyura commented Aug 22, 2024

Seems the last problem is:

Error: Resource not accessible by integration

which seems to be the problem with gitlab ci job itself.

@faern
Copy link
Member

faern commented Aug 22, 2024

Yes indeed. I'm working on that in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants