Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 0.7.0 #70

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Prepare release 0.7.0 #70

merged 1 commit into from
Sep 19, 2024

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Sep 19, 2024

This PR bumps the version of ntfnl and nftnl-sys in preparation of a new release.

TODO


This change is Reviewable

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


nftnl/Cargo.toml line 3 at r1 (raw file):

[package]
name = "nftnl"
version = "1.0.0"

You only need to bump it to 0.7.0. That is also a breaking change. Changing the leftmost non-zero version is considered breaking in the Cargo world. Cargo does not strictly follow the original semver spec. But bumping 0.6.0 to 0.7.0 is a breaking change and appropriate for API breakage.

We can release 1.0.0 when we are happy with the API and think we'll support it semi-long-term. Which I doubt we want in this stage, since we are aware of lots of things missing from the full nftables functionality.

@MarkusPettersson98 MarkusPettersson98 force-pushed the prepare-release branch 2 times, most recently from cd00465 to 05ce048 Compare September 19, 2024 09:59
Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @faern)


nftnl/Cargo.toml line 3 at r1 (raw file):

Previously, faern (Linus Färnstrand) wrote…

You only need to bump it to 0.7.0. That is also a breaking change. Changing the leftmost non-zero version is considered breaking in the Cargo world. Cargo does not strictly follow the original semver spec. But bumping 0.6.0 to 0.7.0 is a breaking change and appropriate for API breakage.

We can release 1.0.0 when we are happy with the API and think we'll support it semi-long-term. Which I doubt we want in this stage, since we are aware of lots of things missing from the full nftables functionality.

You're right! Changed the version bump to 0.7.0 😊

Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2.
Reviewable status: 3 of 4 files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 marked this pull request as ready for review September 19, 2024 10:39
Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@faern faern changed the title Prepare release Prepare release 0.7.0 Sep 19, 2024
@MarkusPettersson98 MarkusPettersson98 merged commit bbb72fd into main Sep 19, 2024
8 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the prepare-release branch September 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants