-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 0.7.0 #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
nftnl/Cargo.toml
line 3 at r1 (raw file):
[package] name = "nftnl" version = "1.0.0"
You only need to bump it to 0.7.0
. That is also a breaking change. Changing the leftmost non-zero version is considered breaking in the Cargo world. Cargo does not strictly follow the original semver spec. But bumping 0.6.0
to 0.7.0
is a breaking change and appropriate for API breakage.
We can release 1.0.0
when we are happy with the API and think we'll support it semi-long-term. Which I doubt we want in this stage, since we are aware of lots of things missing from the full nftables functionality.
cd00465
to
05ce048
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @faern)
nftnl/Cargo.toml
line 3 at r1 (raw file):
Previously, faern (Linus Färnstrand) wrote…
You only need to bump it to
0.7.0
. That is also a breaking change. Changing the leftmost non-zero version is considered breaking in the Cargo world. Cargo does not strictly follow the original semver spec. But bumping0.6.0
to0.7.0
is a breaking change and appropriate for API breakage.We can release
1.0.0
when we are happy with the API and think we'll support it semi-long-term. Which I doubt we want in this stage, since we are aware of lots of things missing from the full nftables functionality.
You're right! Changed the version bump to 0.7.0
😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
05ce048
to
2c72d78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
This PR bumps the version of
ntfnl
andnftnl-sys
in preparation of a new release.TODO
CHANGELOG.md
with missing changes since last release #69 to be mergedPartialOrd
andOrd
forStates
andConntrackStatus
once again.This change is