Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lint option checkAllWarnings #7337

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Dec 12, 2024

This PR aims to enable the AGP lint option checkAllWarnings that enables a range of warnings that are disabled by default. It also generates a baseline that will be cleaned up over time.


This change is Reviewable

@albin-mullvad albin-mullvad added the Android Issues related to Android label Dec 12, 2024
@albin-mullvad albin-mullvad requested review from kl, Rawa and Pururun December 12, 2024 17:18
@albin-mullvad albin-mullvad self-assigned this Dec 12, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the enable-check-all-warnings-lint-option branch from ae213a2 to 81e63f0 Compare December 13, 2024 09:31
@albin-mullvad albin-mullvad merged commit d720161 into main Dec 13, 2024
26 of 27 checks passed
@albin-mullvad albin-mullvad deleted the enable-check-all-warnings-lint-option branch December 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants