Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove select location horizontal pager on TV #7328

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kl
Copy link
Contributor

@kl kl commented Dec 11, 2024


This change is Reviewable

@kl kl added the Android Issues related to Android label Dec 11, 2024
Copy link

linear bot commented Dec 11, 2024

albin-mullvad
albin-mullvad previously approved these changes Dec 11, 2024
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a short summary of the underlying issue in the PR description?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Pururun
Pururun previously approved these changes Dec 11, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does mean that the relay list will animate expand collapse when switching between entry and exit list. This is one of the reasons the horizontal pager was added in the first place. I think it is a fine compromise to get a beta release before the end of the year, but we should note it somewhere.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kl kl dismissed stale reviews from Pururun and albin-mullvad via c2eb623 December 12, 2024 08:23
@kl kl force-pushed the fix-select-location-google-tv-pager-bug-droid-1629 branch from 4e44f77 to c2eb623 Compare December 12, 2024 08:23
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree! I had the same input and asked for a issue to be created, which resulted in: https://linear.app/mullvad/issue/DROID-1639

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the fix-select-location-google-tv-pager-bug-droid-1629 branch from c2eb623 to 15bedbc Compare December 12, 2024 10:06
@Pururun Pururun merged commit b7fb83f into main Dec 12, 2024
26 checks passed
@Pururun Pururun deleted the fix-select-location-google-tv-pager-bug-droid-1629 branch December 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants