-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove select location horizontal pager on TV #7328
Remove select location horizontal pager on TV #7328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a short summary of the underlying issue in the PR description?
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does mean that the relay list will animate expand collapse when switching between entry and exit list. This is one of the reasons the horizontal pager was added in the first place. I think it is a fine compromise to get a beta release before the end of the year, but we should note it somewhere.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
4e44f77
to
c2eb623
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree! I had the same input and asked for a issue to be created, which resulted in: https://linear.app/mullvad/issue/DROID-1639
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
c2eb623
to
15bedbc
Compare
This change is