-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix full-disk access check getting stuck #7326
Conversation
baac372
to
24e0d74
Compare
635637d
to
ca21b64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dlon)
talpid-core/src/split_tunnel/macos/process.rs
line 592 at r2 (raw file):
let need_fda = parse_logger_status( async { //tokio::time::sleep(Duration::from_millis(1)).await;
:O
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @hulthe)
talpid-core/src/split_tunnel/macos/process.rs
line 592 at r2 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
:O
Done.
ca21b64
to
e4ae24c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
The full-disk access check can get stuck when there's no output from
eslogger
, and not timeout correctly. This was due to an incorrectelse
branch intokio::select!
.Fix DES-1452.
This change is