Relay selector doesn't force a blocked state with daita and obfuscation on #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
force-pushed
the
relay-selector-doesnt-force-a-blocked-state-ios-975
branch
2 times, most recently
from
dff2ead to
eced810
Compare
buggmagnet
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Let's make sure we add a test to cover this edge case
Reviewed 6 of 10 files at r1, all commit messages.
Reviewable status: 6 of 10 files reviewed, all discussions resolved
rablador
force-pushed
the
relay-selector-doesnt-force-a-blocked-state-ios-975
branch
2 times, most recently
from
fa9fa20 to
0c9d78e
Compare
buggmagnet
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Reviewed 3 of 10 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
rablador
force-pushed
the
relay-selector-doesnt-force-a-blocked-state-ios-975
branch
from
0c9d78e to
44185ae
Compare
rablador
deleted the
relay-selector-doesnt-force-a-blocked-state-ios-975
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug repro steps:
Observed behavior:
The app tries to use multihop to connect because no dutch DAITA relays have extra_shadowsocks_addr_in.
Expected behavior:
If the app cannot connect to a DAITA relay due to a constraint that only applies to entry relays, the app should enter the blocked state.
This change is