Enable custom Shadowsocks port selection on entry servers in multihop #7263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
force-pushed
the
enable-custom-shadowsocks-port-selection-on-entry-servers-in-ios-955
branch
from
d8b714e to
1478ff6
Compare
buggmagnet
previously approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
mojganii
previously approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Reviewable status:
rablador
force-pushed
the
enable-custom-shadowsocks-port-selection-on-entry-servers-in-ios-955
branch
from
1478ff6 to
23ebe03
Compare
rablador
force-pushed
the
enable-custom-shadowsocks-port-selection-on-entry-servers-in-ios-955
branch
from
23ebe03 to
aa36f07
Compare
mojganii
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Reviewable status: 9 of 12 files reviewed, all discussions resolved (waiting on @buggmagnet)
buggmagnet
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:
rablador
force-pushed
the
enable-custom-shadowsocks-port-selection-on-entry-servers-in-ios-955
branch
from
aa36f07 to
a9a0189
Compare
rablador
deleted the
enable-custom-shadowsocks-port-selection-on-entry-servers-in-ios-955
branch
rablador
restored the
enable-custom-shadowsocks-port-selection-on-entry-servers-in-ios-955
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
Expected Result
The app should just connect using Shadowsocks obfuscation on the entry server.
Actual result
The app enters the blocked state, thinking that the relay constraints are not valid.
This change is