-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy warnings #7261
Fix clippy warnings #7261
Conversation
15d7500
to
213f0ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MarkusPettersson98)
mullvad-daemon/src/macos_launch_daemon.rs
line 81 at r3 (raw file):
/// It must be kept in sync with the path defined in /// `dist-assets/pkg-scripts/postinstall`. const DAEMON_PLIST_PATH: &CStr = c"/Library/LaunchDaemons/net.mullvad.daemon.plist";
:amaze: that Cippy catched this :D
mullvad-cli/src/cmds/relay.rs
line 398 at r3 (raw file):
} // Get active relays which are not bridges.
Hue? shouldn't this be a docstring?
213f0ef
to
30c3cdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dlon and @hulthe)
mullvad-cli/src/cmds/relay.rs
line 398 at r3 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
Hue? shouldn't this be a docstring?
Yes. 🙈
mullvad-daemon/src/macos_launch_daemon.rs
line 81 at r3 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
:amaze: that Cippy catched this :D
So good! ✨
30c3cdd
to
1827267
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
9c9841a
to
a467fd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
a467fd4
to
3c22b1a
Compare
3c22b1a
to
89891f0
Compare
This PR fixes new
clippy
lints from the latest releaseThis change is