Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #7261

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Fix clippy warnings #7261

merged 2 commits into from
Nov 28, 2024

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Nov 28, 2024

This PR fixes new clippy lints from the latest release


This change is Reviewable

@MarkusPettersson98 MarkusPettersson98 force-pushed the fix-clippy-lints branch 2 times, most recently from 15d7500 to 213f0ef Compare November 28, 2024 14:55
@MarkusPettersson98 MarkusPettersson98 marked this pull request as ready for review November 28, 2024 14:56
dlon
dlon previously approved these changes Nov 28, 2024
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MarkusPettersson98)


mullvad-daemon/src/macos_launch_daemon.rs line 81 at r3 (raw file):

    /// It must be kept in sync with the path defined in
    /// `dist-assets/pkg-scripts/postinstall`.
    const DAEMON_PLIST_PATH: &CStr = c"/Library/LaunchDaemons/net.mullvad.daemon.plist";

:amaze: that Cippy catched this :D


mullvad-cli/src/cmds/relay.rs line 398 at r3 (raw file):

    }

    // Get active relays which are not bridges.

Hue? shouldn't this be a docstring?

Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dlon and @hulthe)


mullvad-cli/src/cmds/relay.rs line 398 at r3 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

Hue? shouldn't this be a docstring?

Yes. 🙈


mullvad-daemon/src/macos_launch_daemon.rs line 81 at r3 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

:amaze: that Cippy catched this :D

So good! ✨

hulthe
hulthe previously approved these changes Nov 28, 2024
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@hulthe hulthe added the Daemon Issues related to mullvad-daemon label Nov 28, 2024
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 merged commit 211252b into main Nov 28, 2024
50 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the fix-clippy-lints branch November 28, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daemon Issues related to mullvad-daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants