Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shadowsocks obfuscation ready for production ios 879 #7257

Merged

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Nov 28, 2024

This PR adds WireGuard over Shadowsocks obfuscation in Release and MockRelease builds.
It also amends the Changelog to mention said change.


This change is Reviewable

@buggmagnet buggmagnet added the iOS Issues related to iOS label Nov 28, 2024
@buggmagnet buggmagnet self-assigned this Nov 28, 2024
Copy link

linear bot commented Nov 28, 2024

Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


ios/CHANGELOG.md line 26 at r1 (raw file):

## Unreleased
### Added
- Add WireGuard over Shadowsocks obfuscation. It can be enabled in "VPN settings". This will

Grammatical error. Perhaps "...and will also be used automatically"?

Copy link
Contributor Author

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)


ios/CHANGELOG.md line 26 at r1 (raw file):

Previously, acb-mv wrote…

Grammatical error. Perhaps "...and will also be used automatically"?

I'm not sure I see it, there's a dot . after the second sentence, so both this, and the third one are valid (I copy pasted this from the desktop release notes to be honest)

Did you mean that there should be a comma , instead of a dot . ?

@acb-mv
Copy link
Contributor

acb-mv commented Nov 28, 2024

ios/CHANGELOG.md line 26 at r1 (raw file):

Previously, buggmagnet wrote…

I'm not sure I see it, there's a dot . after the second sentence, so both this, and the third one are valid (I copy pasted this from the desktop release notes to be honest)

Did you mean that there should be a comma , instead of a dot . ?

Sorry, I missed the "Th" at the start of "This will", and the browser helpfully showed "is will" at the start of the next line, which I assumed was meant to be an "it will". Carry on.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the make-shadowsocks-obfuscation-ready-for-production-ios-879 branch from 408e15e to 3934bc1 Compare December 2, 2024 11:42
Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the make-shadowsocks-obfuscation-ready-for-production-ios-879 branch from 3934bc1 to 080e85f Compare December 2, 2024 13:59
@buggmagnet buggmagnet merged commit adc7c4b into main Dec 2, 2024
14 checks passed
@buggmagnet buggmagnet deleted the make-shadowsocks-obfuscation-ready-for-production-ios-879 branch December 2, 2024 14:04
Copy link

github-actions bot commented Dec 2, 2024

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants