-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make shadowsocks obfuscation ready for production ios 879 #7257
Make shadowsocks obfuscation ready for production ios 879 #7257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/CHANGELOG.md
line 26 at r1 (raw file):
## Unreleased ### Added - Add WireGuard over Shadowsocks obfuscation. It can be enabled in "VPN settings". This will
Grammatical error. Perhaps "...and will also be used automatically"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)
ios/CHANGELOG.md
line 26 at r1 (raw file):
Previously, acb-mv wrote…
Grammatical error. Perhaps "...and will also be used automatically"?
I'm not sure I see it, there's a dot .
after the second sentence, so both this, and the third one are valid (I copy pasted this from the desktop release notes to be honest)
Did you mean that there should be a comma ,
instead of a dot .
?
Previously, buggmagnet wrote…
Sorry, I missed the "Th" at the start of "This will", and the browser helpfully showed "is will" at the start of the next line, which I assumed was meant to be an "it will". Carry on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
408e15e
to
3934bc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
3934bc1
to
080e85f
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
This PR adds WireGuard over Shadowsocks obfuscation in
Release
andMockRelease
builds.It also amends the Changelog to mention said change.
This change is