Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log failure reason when trying DNS managers #7253

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

hulthe
Copy link
Contributor

@hulthe hulthe commented Nov 28, 2024

Might make it a bit easier to diagnose DNS issues on linux.

Example output:

[2024-11-28 11:25:05.950][talpid_core::dns][INFO] Setting DNS servers: Tunnel DNS: {10.64.0.1} Non-tunnel DNS: {}
[2024-11-28 11:25:05.951][talpid_core::dns::imp][DEBUG] Can't manage DNS using systemd-resolved: systemd-resolved operation failed
[2024-11-28 11:25:05.952][talpid_dbus::network_manager][DEBUG] /etc/resolv.conf differs from reference resolv.conf, therefore NM is not managing DNS
[2024-11-28 11:25:05.952][talpid_core::dns::imp][DEBUG] Can't manage DNS using network manager: NetworkManager is not managing DNS
[2024-11-28 11:25:05.952][talpid_core::dns::imp][DEBUG] Can't manage DNS using resolveconf: Failed to detect 'resolvconf' program
[2024-11-28 11:25:05.952][talpid_core::dns::imp::static_resolv_conf][DEBUG] No DNS state backup to restore
[2024-11-28 11:25:05.952][talpid_core::dns::imp][DEBUG] Managing DNS via /etc/resolv.conf

This change is Reviewable

@hulthe hulthe requested a review from dlon November 28, 2024 10:31
@hulthe hulthe added the Daemon Issues related to mullvad-daemon label Nov 28, 2024
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@hulthe hulthe force-pushed the improved-dns-fallback-logging-linux branch from 882e374 to d487d91 Compare November 28, 2024 15:52
@hulthe hulthe merged commit 5e5bc4e into main Nov 29, 2024
53 checks passed
@hulthe hulthe deleted the improved-dns-fallback-logging-linux branch November 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daemon Issues related to mullvad-daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants