Remove EventCallback

[Serock3]

The event callback was a dynamically typed async closure, which resulted in verbose type bounds. I replaced it with a simple concrete type, as there was only ever a single instance of it anyway.

---

This change is 

[hulthe]

Reviewed 2 of 5 files at r2.
Reviewable status: 1 of 5 files reviewed, all discussions resolved

---

talpid-openvpn/src/lib.rs line 305 at r2 (raw file):

            openvpn_init_args,
            event_server::OpenvpnEventProxyImpl {
                event_hook: tokio::sync::Mutex::new(event_hook),

If you use tokios mpsc-channels you won't need to wrap this in a Mutex

[Serock3]

Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @hulthe)

---

talpid-openvpn/src/lib.rs line 305 at r2 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

If you use tokios mpsc-channels you won't need to wrap this in a Mutex

I opted to simply clone the event_hook on each call for simplicity. I assume that is quite cheep to do, although the neither the docs for tokio or futures mpsc mention anything about the cost.

[hulthe]

LGTM 💰

Reviewed 2 of 5 files at r2, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

talpid-openvpn/src/lib.rs line 305 at r2 (raw file):

Previously, Serock3 (Sebastian Holmin) wrote…

I opted to simply clone the event_hook on each call for simplicity. I assume that is quite cheep to do, although the neither the docs for tokio or futures mpsc mention anything about the cost.

It's holding an Arc internally, so the cost is just Cloning that.

I personally still would prefer using tokios channel and avoiding the clones, but I won't make a fuss of it :)