Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor address cache in mullvad-api #7248

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Refactor address cache in mullvad-api #7248

merged 3 commits into from
Dec 2, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented Nov 27, 2024 •
edited
Loading

  • Implement DnsResolver for the AddressCache. This decouples it from the REST client.
  • Remove "fallback on DNS resolution" logic. Only give the geoip client an actual DNS resolver. Let the main client fail if it tries to resolve anything that isn't api.mullvad.net.
  • Use URI host for SNI.

This change is Reviewable

@dlon dlon force-pushed the simplify-api-addr-cache branch from be1395e to 02dc0d8 Compare November 27, 2024 15:20
@hulthe hulthe added the Daemon Issues related to mullvad-daemon label Nov 27, 2024
@dlon dlon changed the title Refactor mullvad-api Refactor address cache in mullvad-api Nov 28, 2024
MarkusPettersson98
MarkusPettersson98 previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the simplify-api-addr-cache branch from 4cecc5a to d74092d Compare December 2, 2024 12:49
@dlon dlon force-pushed the simplify-api-addr-cache branch from d74092d to fae230d Compare December 2, 2024 12:59
MarkusPettersson98
MarkusPettersson98 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the simplify-api-addr-cache branch from fa0f653 to 354665e Compare December 2, 2024 15:00
@dlon dlon merged commit 8bda210 into main Dec 2, 2024
59 checks passed
@dlon dlon deleted the simplify-api-addr-cache branch December 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusPettersson98 MarkusPettersson98 MarkusPettersson98 approved these changes

Assignees
No one assigned
Labels
Daemon Issues related to mullvad-daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlon @MarkusPettersson98 @hulthe