Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mullvad-api for iOS #7238

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Fix mullvad-api for iOS #7238

merged 3 commits into from
Nov 26, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented Nov 26, 2024

Also, build mullvad-api in the CI workflow.

Close IOS-950.


This change is Reviewable

@dlon dlon requested review from buggmagnet and rablador November 26, 2024 08:13
Copy link

linear bot commented Nov 26, 2024

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

buggmagnet
buggmagnet previously approved these changes Nov 26, 2024
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the ios-fix-missing-resolver branch from 7f56d0e to d437b63 Compare November 26, 2024 09:58
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon merged commit b0ddb2d into main Nov 26, 2024
49 of 50 checks passed
@dlon dlon deleted the ios-fix-missing-resolver branch November 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants