Improve nseventforwarder

[MarkusPettersson98]

This PR improves the nseventforwarder implementation in the following ways:

• Use clearly named variables
• Add some more documentation to distinguish what's happening on the nodejs vs rust side
• Get rid of the static Mutex, effectively allowing multiple nsevent-callback to be running at once. Because why not

This is not critical in any way, but especially the static Mutex bothered me since it didn't seem necessary :-)

---

This change is 

[hulthe]

Nice! I'm also happy to see the mutex gone :)

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

---

desktop/packages/nseventforwarder/nseventforwarder-rs/lib.rs line 57 at r1 (raw file):

                NSEventMask::LeftMouseDown | NSEventMask::RightMouseDown,
                &RcBlock::new(move |nsevent| {
                    nsevent_callback(nsevent);

⛏️ This closure is redundant, you can pass nsevent_callback directly (if you change its return type)

&RcBlock::new(nsevent_callback)

[MarkusPettersson98]

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @hulthe)

---

desktop/packages/nseventforwarder/nseventforwarder-rs/lib.rs line 57 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

⛏️ This closure is redundant, you can pass nsevent_callback directly (if you change its return type)

&RcBlock::new(nsevent_callback)

Nice one! ✨

[hulthe]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved