Add test for in-tunnel IP leak via APR requests on Linux (MLLVD-CR-24-03) #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
force-pushed
the
add-e2e-tests-for-arp-ping-leak-des-1438
branch
from
ba7cedf to
919fcbb
Compare
dlon
previously approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
MarkusPettersson98
force-pushed
the
add-e2e-tests-for-arp-ping-leak-des-1438
branch
from
919fcbb to
c655e51
Compare
MarkusPettersson98
force-pushed
the
add-e2e-tests-for-arp-ping-leak-des-1438
branch
from
c655e51 to
8bd6218
Compare
dlon
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
MarkusPettersson98
deleted the
add-e2e-tests-for-arp-ping-leak-des-1438
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an end-to-end test to check that the app properly protects against leaking the private in-tunnel IP via ARP requests on Linux. This is a follow up to #7141.
I confirmed that the test works by first running the test without #7141 and see that the in-tunnel IP indeed can leak. Then I ran the test a second time with #7141 and observed no leaks.
Test runs
🔴 Without #7141: https://github.com/mullvad/mullvadvpn-app/actions/runs/11851540636/job/33028399991
✔️ With #7141: https://github.com/mullvad/mullvadvpn-app/actions/runs/11851490017/job/33028260661
Misc
This PR additionally moves all audit-related end-to-end tests to a newly created module called
audits. This makes it easier to track which audit issues we automatically check for regressions.This change is