Fix filter apply button being enabled with zero providers #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
force-pushed
the
apply-button-enabled-incorrectly-and-provider-count-mismatch-ios-919
branch
from
8cb08ef to
a0e2551
Compare
rablador
commented
Nov 12, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
ios/MullvadVPN/View controllers/RelayFilter/RelayFilterDataSource.swift line 288 at r1 (raw file):
} func tableView(_ tableView: UITableView, heightForHeaderInSection section: Int) -> CGFloat {
Opportunistically removed some "dead" code. Not related to PR.
buggmagnet
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
acb-mv
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
pinkisemils
force-pushed
the
apply-button-enabled-incorrectly-and-provider-count-mismatch-ios-919
branch
from
a0e2551 to
aa56e46
Compare
pinkisemils
force-pushed
the
apply-button-enabled-incorrectly-and-provider-count-mismatch-ios-919
branch
from
aa56e46 to
60cde45
Compare
pinkisemils
deleted the
apply-button-enabled-incorrectly-and-provider-count-mismatch-ios-919
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching between ownership at filter view, the apply button is enabled while no providers are selected and the provider pile shows wrong number for providers.
This change is