Fix connection timeout errors caused by far away relays #7119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
previously approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
MarkusPettersson98
force-pushed
the
fix-connection-timeout-errors-caused-by-far-away-relays-des-1419
branch
3 times, most recently
from
724fbe9 to
d74d0e0
Compare
MarkusPettersson98
force-pushed
the
fix-connection-timeout-errors-caused-by-far-away-relays-des-1419
branch
2 times, most recently
from
e160eed to
be778b2
Compare
dlon
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status:
MarkusPettersson98
force-pushed
the
fix-connection-timeout-errors-caused-by-far-away-relays-des-1419
branch
4 times, most recently
from
b695dd4 to
b67023c
Compare
Limit relay selection in `test_quantum_resistant_multihop_shadowsocks_tunnel` to reduce flakiness Hopefully this should be able to (at least partially) mitigate timeout-related issues.
Limit relay selection in `test_quantum_resistant_multihop_udp2tcp_tunnel` to reduce flakiness. Hopefully this should be able to (at least partially) mitigate timeout-related issues.
Limit relay selection in `test_quantum_resistant_tunnel` to reduce flakiness. Hopefully this should be able to (at least partially) mitigate timeout related issues.
Limit relay selection in `test_multihop` to reduce flakiness. Hopefully this should be able to (at least partially) mitigate timeout related issues.
Limit relay selection in `test_wireguard_over_shadowsocks` to reduce flakiness. Hopefully this should be able to (at least partially) mitigate timeout related issues.
MarkusPettersson98
force-pushed
the
fix-connection-timeout-errors-caused-by-far-away-relays-des-1419
branch
from
b67023c to
09b0542
Compare
MarkusPettersson98
deleted the
fix-connection-timeout-errors-caused-by-far-away-relays-des-1419
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some changes to end-to-end test cases which has been shown to be particularly prone to timeout issues during the connecting phase. In an attempt to reduce the perceived flakiness, we restrict what relays may be selected to relays which are geographically close to the client under test in order to reduce the amount of latency in the system.
Looks promising: https://github.com/mullvad/mullvadvpn-app/actions/runs/11659693517/job/32460901751
This change is