Filter pills overflow doesnt expand vertically ios 897 #7116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojganii
force-pushed
the
filter-pills-overflow-doesnt-expand-vertically-ios-897
branch
8 times, most recently
from
6f3fa47 to
d5dd34e
Compare
buggmagnet
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Reviewed 5 of 9 files at r1, 1 of 2 files at r2, 1 of 2 files at r4, 5 of 5 files at r5, all commit messages.
Reviewable status: 10 of 11 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
filter-pills-overflow-doesnt-expand-vertically-ios-897
branch
from
d5dd34e to
f93536f
Compare
buggmagnet
deleted the
filter-pills-overflow-doesnt-expand-vertically-ios-897
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables chips in the location view to flow vertically when there is no remaining horizontal space. The new implementation can also be reused for the features indicator in the future.
This change is