Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relay tests #7112

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix relay tests #7112

merged 1 commit into from
Oct 31, 2024

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Oct 31, 2024


This change is Reviewable

@rablador rablador added bug iOS Issues related to iOS labels Oct 31, 2024
@rablador rablador self-assigned this Oct 31, 2024
Copy link

linear bot commented Oct 31, 2024

IOS-872 Fix relay tests

Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks for a relay name by quering text in the UI. Without daita enabled this text will have a trailing space, which then fails the test due to missing relay name.

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the fix-relay-tests-ios-872 branch from e830016 to 6c936c8 Compare October 31, 2024 15:35
@buggmagnet buggmagnet merged commit 97072e2 into main Oct 31, 2024
11 checks passed
@buggmagnet buggmagnet deleted the fix-relay-tests-ios-872 branch October 31, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants