-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Fix" CVE-2024-49761 by just ignoring rexml for now #7104
"Fix" CVE-2024-49761 by just ignoring rexml for now #7104
Conversation
7b836aa
to
1d980eb
Compare
Would it not be better to ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also do that, yes. I'll make the change
Reviewable status: 0 of 4 files reviewed, all discussions resolved
1d980eb
to
bc77ad1
Compare
You still need an expiry date. I pointed this out on slack. No ignore is allowed to be indefinite. See instructions at top of root |
bc77ad1
to
2eb7337
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faern no matter what I tried yesterday, I couldn't get osv-scanner
to ignore the vulnerability when I was using an expiry date, the tool was just complaining about an invalid format.
Clearly I was doing something wrong, cause today it worked immediately.
Should be fixed now.
Reviewable status: 0 of 4 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r2, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
154ba23
to
d4d6a19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
ci/ios/upload-vm/osv-scanner.toml
line 2 at r5 (raw file):
[[PackageOverrides]] effectiveUntil = 2025-04-01
An ignore longer than three months should ideally have a comment about why. But not critical.
I'm trying to clarify the rules around ignoring entire packages with this PR: #7115 |
d4d6a19
to
542b921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
This PR fixes CVE-2024-49761 by upgrading rexml
This change is