Remove explanatory text for Direct only in settings

[rablador]

---

This change is 

[linear]

IOS-895 Remove explanatory text for _direct only_/_smart routing_ in settings

[pinkisemils]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[mojganii]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/View controllers/Settings/SettingsDataSource.swift line 139 at r1 (raw file):

    }

    func tableView(_ tableView: UITableView, heightForHeaderInSection section: Int) -> CGFloat {

we can remove all three functions when we don't have footer anymore.

Code snippet:

    func tableView(_ tableView: UITableView, heightForHeaderInSection section: Int) -> CGFloat {
        UITableView.automaticDimension
    }

    func tableView(_ tableView: UITableView, viewForFooterInSection section: Int) -> UIView? {
        nil
    }

    func tableView(_ tableView: UITableView, heightForFooterInSection section: Int) -> CGFloat {
        0
    }

---

ios/MullvadVPN/View controllers/Settings/SettingsDataSource.swift line 175 at r1 (raw file):

            snapshot.appendSections([.daita])
            snapshot.appendItems([.daita], toSection: .daita)
            snapshot.appendItems([.daitaDirectOnly], toSection: .daita)

both can be replace by one :

Code snippet:

snapshot.appendItems([.daita,.daitaDirectOnly], toSection: .daita)

[rablador]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/Settings/SettingsDataSource.swift line 139 at r1 (raw file):

Previously, mojganii wrote…

we can remove all three functions when we don't have footer anymore.

The header function can indeed be removed, but unfortunately not the footer ones. Apple adds default section spacing that we don't want.

---

ios/MullvadVPN/View controllers/Settings/SettingsDataSource.swift line 175 at r1 (raw file):

Previously, mojganii wrote…

both can be replace by one :

Done.

[rablador]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @mojganii and @pinkisemils)

---

ios/MullvadVPN/View controllers/Settings/SettingsDataSource.swift line 139 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

The header function can indeed be removed, but unfortunately not the footer ones. Apple adds default section spacing that we don't want.

Oh, but we can of course remedy this by setting footer height on the tableview itself. Se tableView.sectionFooterHeight = 0 above.

[mojganii]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @pinkisemils)