-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug information to requests when running UITests #6976
Add debug information to requests when running UITests #6976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPNUITests/Networking/PartnerAPIClient.swift
line 100 at r1 (raw file):
print("Request successful") do { if data.isEmpty == false {
!data.isEmpty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but just wondering if this should be in main
or if it's something that just needs to be used temporarily for troubleshooting the current 403
response issue by triggering runs on this branch?
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
After discussin offline, and after the changes introduced in |
🚨 End to end tests failed. Please check the failed workflow run. |
This PR prints debug information about each partner API requests in the console logs, and carefully redacts away any access token and account number when doing so.
This change is