Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug information to requests when running UITests #6976

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Oct 14, 2024

This PR prints debug information about each partner API requests in the console logs, and carefully redacts away any access token and account number when doing so.


This change is Reviewable

@buggmagnet buggmagnet added the iOS Issues related to iOS label Oct 14, 2024
@buggmagnet buggmagnet self-assigned this Oct 14, 2024
Copy link

linear bot commented Oct 14, 2024

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


ios/MullvadVPNUITests/Networking/PartnerAPIClient.swift line 100 at r1 (raw file):

                print("Request successful")
                do {
                    if data.isEmpty == false {

!data.isEmpty

Copy link
Collaborator

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but just wondering if this should be in main or if it's something that just needs to be used temporarily for troubleshooting the current 403 response issue by triggering runs on this branch?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

@buggmagnet buggmagnet closed this Oct 15, 2024
@buggmagnet
Copy link
Contributor Author

After discussin offline, and after the changes introduced in 291615ef3 We decided to drop this work.

Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants