Refactor buttons to use UIButton.Configuration

[mojganii]

This PR refactors the buttons to use UIButton.Configuration for their configuration.

---

This change is 

[linear]

IOS-856 Fix deprecation Warning for `contentEdgeInsets` in UIButton

[rablador]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/Login/AccountInputGroupView.swift line 111 at r1 (raw file):

        config.contentInsets = UIMetrics.textFieldMargins.toDirectionalInsets
        config.baseForegroundColor = .AccountTextField.NormalState.textColor
        button.configuration = config

Nit: I think we should either add all available configurations (including eg.title) or just the one that is deprecated. Title color isn't deprecated and can be left out if we want to.

---

ios/MullvadVPN/Views/CustomButton.swift line 43 at r1 (raw file):

            return UIColor.AppButton.normalTitleColor
        case .disabled:
            return UIColor.AppButton.disabledTitleColor.withAlphaComponent(0.5)

Is this ok to remove? This color has a value of 1.0 alpha and without the 0.5 it is the same color as .highlightedTitleColor.

[mojganii]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/View controllers/Login/AccountInputGroupView.swift line 111 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Nit: I think we should either add all available configurations (including eg.title) or just the one that is deprecated. Title color isn't deprecated and can be left out if we want to.

Good catch!
we have to put all together in configuration.

---

ios/MullvadVPN/Views/CustomButton.swift line 43 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Is this ok to remove? This color has a value of 1.0 alpha and without the 0.5 it is the same color as .highlightedTitleColor.

it's correct both have the same value but we are using them separately in the code. so I suggest to not let them mix up when it's supposed to have different style for different states.

[rablador]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[buggmagnet]

It looks like the reconnect button is gone

Reviewed 6 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

---

ios/MullvadVPN/Views/InAppPurchaseButton.swift line 78 at r2 (raw file):

    }

    private func getActivityIndicatorRect(forContentRect contentRect: CGRect) -> CGRect {

nit
There's no need to add a get prefix here, the name of the function follows convention and Apple's guidelines

[rablador]

Reviewed all commit messages.
Reviewable status: 5 of 8 files reviewed, 1 unresolved discussion (waiting on @buggmagnet and @mojganii)

[rablador]

Reviewed 8 of 8 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/Views/AppButton.swift line 109 at r4 (raw file):

        imageAlignment = .trailing
        titleAlignment = .leading
        isHighlighted = false

This attribute is false by default.

[buggmagnet]

Reviewed 6 of 8 files at r4.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/Extensions/CGSize+Helpers.swift line 13 at r4 (raw file):

extension CGSize {
    // Function to deduct insets from CGSize
    func deducting(insets: NSDirectionalEdgeInsets) -> CGSize {

nit
It's deducting offsets from a NSDirectionalEdgeInsets

---

ios/MullvadVPN/Extensions/CGSize+Helpers.swift line 14 at r4 (raw file):

    // Function to deduct insets from CGSize
    func deducting(insets: NSDirectionalEdgeInsets) -> CGSize {
        let newWidth = self.width - (insets.leading + insets.trailing)

not need for self here and below

---

ios/MullvadVPN/Extensions/UIImage+Helpers.swift line 14 at r4 (raw file):

    // Function to resize image while keeping aspect ratio
    func resizeImage(targetSize: CGSize) -> UIImage {
        let widthRatio = targetSize.width / self.size.width

no need for self here and below

[mojganii]

Reviewable status: 5 of 10 files reviewed, 5 unresolved discussions (waiting on @buggmagnet and @rablador)

---

ios/MullvadVPN/Extensions/CGSize+Helpers.swift line 14 at r4 (raw file):

Previously, buggmagnet wrote…

not need for self here and below

Done.

---

ios/MullvadVPN/Extensions/UIImage+Helpers.swift line 14 at r4 (raw file):

Previously, buggmagnet wrote…

no need for self here and below

Done.

---

ios/MullvadVPN/Views/AppButton.swift line 109 at r4 (raw file):

Previously, rablador (Jon Petersson) wrote…

This attribute is false by default.

true. I've forgotten to remove that.

---

ios/MullvadVPN/Views/InAppPurchaseButton.swift line 78 at r2 (raw file):

Previously, buggmagnet wrote…

nit
There's no need to add a get prefix here, the name of the function follows convention and Apple's guidelines

Fair enough!

[rablador]

Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @mojganii)

[buggmagnet]

Reviewed 1 of 8 files at r4, 5 of 5 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

[rablador]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

[rablador]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.