Add settings e2e test #6776
Merged
Add settings e2e test #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raksooo
force-pushed
the
write-gui-tests-for-auto-connect-lan-settings-des-275
branch
from
4f77c19 to
84c1ba2
Compare
dlon
force-pushed
the
write-gui-tests-for-auto-connect-lan-settings-des-275
branch
from
84c1ba2 to
586ec02
Compare
raksooo
commented
Oct 15, 2024
There was a problem hiding this comment.
Reviewed 5 of 7 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @raksooo)
GUI settings are not cleaned up between tests
dlon
force-pushed
the
write-gui-tests-for-auto-connect-lan-settings-des-275
branch
from
5da9242 to
95c0f9b
Compare
dlon
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Reviewed 4 of 7 files at r2, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
dlon
deleted the
write-gui-tests-for-auto-connect-lan-settings-des-275
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add settings e2e test that tests:
This change is