Bump iOS version to 2023.5 #6722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
requested changes
Sep 2, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/Configurations/Version.xcconfig line 5 at r1 (raw file):
// Marketing version, aka major.minor MARKETING_VERSION = 2024.5
We already shipped 2024.5, this should be 2024.6
buggmagnet
previously approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
rablador
previously approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
pinkisemils
dismissed stale reviews from rablador and buggmagnet
via
1b5e255
pinkisemils
force-pushed
the
bump-ios-version
branch
from
e635ad3 to
1b5e255
Compare
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We released 2024.5, now we must bump the version in
main.This change is