Inject tunnel settings in RelaySelectorWrapper

[buggmagnet]

This PR changes RelaySelectorWrapper to not create tunnel settings instances by itself anymore.
Instead, we now pass tunnel settings when we need to select a relay to always rely upon settings that were read from cache.

This fixes a bug where saved user settings would otherwise not be respected when upgrading the app to a new version.

---

This change is 

[linear]

IOS-808 Fix LatestTunnelSettings being recreated not from cache

[mojganii]

Reviewable status: 0 of 11 files reviewed, all discussions resolved

[rablador]

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

---

ios/MullvadVPNTests/MullvadREST/Relay/RelaySelectorWrapperTests.swift line 90 at r1 (raw file):

    }

    func testCanSelectRelayWithMultihopOffAndDaitaOn() throws {

This test seem to indirectly test the same thing as before, but using multihopWithoutDaitaConstraints for a test that explicitly states MultihopOffAndDaitaOn is a little confusing.

[rablador]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

[buggmagnet]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

---

ios/MullvadVPNTests/MullvadREST/Relay/RelaySelectorWrapperTests.swift line 90 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

This test seem to indirectly test the same thing as before, but using multihopWithoutDaitaConstraints for a test that explicitly states MultihopOffAndDaitaOn is a little confusing.

You're right, the test was completely bogus, I fixed it, thanks for catching that !

[rablador]

Reviewable status: complete! all files reviewed, all discussions resolved

[rablador]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.