Fix test_split_tunnel #6682
Merged
Fix test_split_tunnel #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulthe
previously approved these changes
Aug 27, 2024
dlon
force-pushed
the
fix-icmp-priv
branch
4 times, most recently
from
583a3b8 to
ec8bbfe
Compare
hulthe
reviewed
Aug 28, 2024
hulthe
reviewed
Aug 28, 2024
hulthe
approved these changes
Aug 29, 2024
Raw ICMP isn't allowed on all platforms for unprivileged users. Instead: * Use SOCK_DGRAM, where possible * Use 'ping' command, since SOCK_DGRAM isn't allowed on some older Linux distros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinguses raw sockets rather thanSOCK_DGRAMby default. This only works as root.Related test run: https://github.com/mullvad/mullvadvpn-app/actions/runs/10593508501
This change is