Ignore micromatch CVE-2024-4067 and rexml CVE-2024-43398 #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raksooo
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 3 files reviewed, all discussions resolved
buggmagnet
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osv-scannerhas started complaining aboutmicromatchandrexml(one in desktop frontend, and one in iOS helper scripts). Both are regular expression DoS attacks which does not affect us, since we won't run untrusted input in it.This is not the first time
rexmlhas been having these silly[1] issues. It has proven to be problematic to just upgraderexml(thank you ruby package management). So this time I opted for just ignoring it... For now 🤷[1]: Silly as in they don't affect us, and basically all regular expression libraries have a metric ton of DoS all the time. So it's taxing.
This change is